send path challenge of 8 bytes. add Ack block

libi2pd/SSU2Session.cpp

@@ -1660,9 +1660,7 @@ namespace transport
 					LogPrint (eLogDebug, "SSU2: Path response");
 					if (m_PathChallenge)
 					{
-						i2p::data::Tag<32> hash;
+						if (buf64toh (buf + offset) == m_PathChallenge->first)
-						SHA256 (buf + offset, size, hash);
-						if (hash == m_PathChallenge->first)
 						{
 							m_RemoteEndpoint = m_PathChallenge->second;
 							m_PathChallenge.reset (nullptr);
@@ -3091,14 +3089,15 @@ namespace transport
 		payloadSize += CreateAddressBlock (payload + payloadSize, m_MaxPayloadSize  - payloadSize, to);
 		// path challenge block
 		payload[payloadSize] = eSSU2BlkPathChallenge;
-		size_t len = m_Server.GetRng ()() % (m_MaxPayloadSize - payloadSize - 3 - 8) + 8; // 8 bytes min
+		uint64_t challenge;
-		htobe16buf (payload + payloadSize + 1, len);
+		RAND_bytes ((uint8_t *)&challenge, 8);		
-		payloadSize += 3;
+		htobe16buf (payload + payloadSize + 1, 8); // always 8 bytes
-		m_PathChallenge = std::make_unique<std::pair<i2p::data::Tag<32>, boost::asio::ip::udp::endpoint> >();
+		htobuf64 (payload + payloadSize + 3, challenge);
-		RAND_bytes (payload + payloadSize, len);
+		payloadSize += 11;
-			SHA256 (payload + payloadSize, len, m_PathChallenge->first);
+		m_PathChallenge = std::make_unique<std::pair<uint64_t, boost::asio::ip::udp::endpoint> >(challenge, to);	
-			m_PathChallenge->second = to;
+		// ack block
-		payloadSize += len;
+		if (payloadSize < m_MaxPayloadSize)
+			payloadSize += CreateAckBlock (payload + payloadSize, m_MaxPayloadSize - payloadSize);
 		// padding block
 		if (payloadSize < m_MaxPayloadSize)
 			payloadSize += CreatePaddingBlock (payload + payloadSize, m_MaxPayloadSize - payloadSize);

libi2pd/SSU2Session.h

@@ -394,7 +394,7 @@ namespace transport
 			boost::asio::deadline_timer m_ConnectTimer;
 			SSU2TerminationReason m_TerminationReason;
 			size_t m_MaxPayloadSize;
-			std::unique_ptr<std::pair<i2p::data::Tag<32>, boost::asio::ip::udp::endpoint> > m_PathChallenge;
+			std::unique_ptr<std::pair<uint64_t, boost::asio::ip::udp::endpoint> > m_PathChallenge;
 			std::unordered_map<uint32_t, uint32_t> m_ReceivedI2NPMsgIDs; // msgID -> timestamp in seconds
 			uint64_t m_LastResendTime, m_LastResendAttemptTime; // in milliseconds
 			int m_NumRanges;