fixed #2183. Give more time to close streams after session disconnect if needed

libi2pd/Streaming.h

@@ -326,6 +326,7 @@ namespace stream
 			void SendPing (std::shared_ptr<const i2p::data::LeaseSet> remote);
 			void DeleteStream (std::shared_ptr<Stream> stream);
 			bool DeleteStream (uint32_t recvStreamID);
+			size_t GetNumStreams () const { return m_Streams.size (); };
 			void SetAcceptor (const Acceptor& acceptor);
 			void ResetAcceptor ();
 			bool IsAcceptorSet () const { return m_Acceptor != nullptr; };

libi2pd_client/SAM.cpp

@@ -43,23 +43,21 @@ namespace client
 			m_Stream->AsyncClose ();
 			m_Stream = nullptr;
 		}
-		auto Session = m_Owner.FindSession(m_ID);
 		switch (m_SocketType)
 		{
 			case eSAMSocketTypeSession:
 				m_Owner.CloseSession (m_ID);
 			break;
 			case eSAMSocketTypeStream:
-			{
+			break;
-				break;
-			}
 			case eSAMSocketTypeAcceptor:
 			case eSAMSocketTypeForward:
 			{
-				if (Session)
+				auto session = m_Owner.FindSession(m_ID);
+				if (session)
 				{
-					if (m_IsAccepting && Session->GetLocalDestination ())
+					if (m_IsAccepting && session->GetLocalDestination ())
-						Session->GetLocalDestination ()->StopAcceptingStreams ();
+						session->GetLocalDestination ()->StopAcceptingStreams ();
 				}
 				break;
 			}
@@ -1479,15 +1477,37 @@ namespace client
 			session->StopLocalDestination ();
 			session->Close ();
 			if (m_IsSingleThread)
+				ScheduleSessionCleanupTimer (session); // let all session's streams close
+		}
+	}
+
+	void SAMBridge::ScheduleSessionCleanupTimer (std::shared_ptr<SAMSession> session)
+	{
+		auto timer = std::make_shared<boost::asio::deadline_timer>(GetService ());
+		timer->expires_from_now (boost::posix_time::seconds(5)); // postpone destination clean for 5 seconds
+		timer->async_wait (std::bind (&SAMBridge::HandleSessionCleanupTimer, this, std::placeholders::_1, session, timer));
+	}	
+		
+	void SAMBridge::HandleSessionCleanupTimer (const boost::system::error_code& ecode,
+		std::shared_ptr<SAMSession> session, std::shared_ptr<boost::asio::deadline_timer> timer)
+	{
+		if (ecode != boost::asio::error::operation_aborted && session)
+		{
+			auto dest = session->GetLocalDestination ();
+			if (dest)
 			{
-				auto timer = std::make_shared<boost::asio::deadline_timer>(GetService ());
+				auto streamingDest = dest->GetStreamingDestination ();
-				timer->expires_from_now (boost::posix_time::seconds(5)); // postpone destination clean for 5 seconds
+				auto numStreams = streamingDest->GetNumStreams ();
-				timer->async_wait ([timer, session](const boost::system::error_code& ecode)
+				if (numStreams > 0)
 				{
-					// session's destructor is called here
+					LogPrint (eLogInfo, "SAM: Session ", session->Name, " still has ", numStreams, " streams");
-				});
+					ScheduleSessionCleanupTimer (session);
+				}	
+				else
+					LogPrint (eLogDebug, "SAM: Session ", session->Name, " terminated");
 			}	
 		}	
+		// session's destructor is called here unless rescheduled
 	}	
 		
 	std::shared_ptr<SAMSession> SAMBridge::FindSession (const std::string& id) const

libi2pd_client/SAM.h

@@ -1,5 +1,5 @@
 /*
-* Copyright (c) 2013-2024, The PurpleI2P Project
+* Copyright (c) 2013-2025, The PurpleI2P Project
 *
 * This file is part of Purple i2pd project and licensed under BSD3
 *
@@ -271,6 +271,10 @@ namespace client
 			void ReceiveDatagram ();
 			void HandleReceivedDatagram (const boost::system::error_code& ecode, std::size_t bytes_transferred);
 
+			void ScheduleSessionCleanupTimer (std::shared_ptr<SAMSession> session);
+			void HandleSessionCleanupTimer (const boost::system::error_code& ecode,
+				std::shared_ptr<SAMSession> session, std::shared_ptr<boost::asio::deadline_timer> timer);	                                
+			
 		private:
 
 			bool m_IsSingleThread;